55257 Commits

Author SHA1 Message Date
Brian Coca
516a114ef6 option deprecations show alternatives (#86032)
Give users a helpful hint on what to do to address the deprecation
2025-10-23 12:44:43 -04:00
Sloane Hertel
68f5a7ca1c Update issue templates with suggestion to exclude Galaxy server secrets and general reminder (#85481) 2025-10-23 14:53:45 +00:00
Patrick Kingston
087931546d Remove deprecated safe_eval (#86019)
* Remove safe_eval from codebase

Resolves deprecations in 85996 and 85999

* Remove deprecations from sanity ignores

* Add changelog fragment

* Add newline to file

* Remove unused imports
2025-10-22 12:22:14 -04:00
Sloane Hertel
df34bf9e70 Update win_exec_wrapper integration test to match #86029 (#86052)
* Remove assertion now that there is no warning
2025-10-21 17:56:18 -04:00
sivel / Matt Martz
e4b4787c02 Soft deprecate ansible.module_utils.six (#86048) 2025-10-21 16:20:55 -05:00
Martin Krizek
6dd48814f2 Remove test/units/module_utils/compat/test_datetime.py (#86045)
Follow up on #86018
2025-10-21 14:17:47 -04:00
Abhijeet Kasurde
ef53d63953 package_facts: typecast bytes to string while returning facts (#85939)
Fixes: #85937

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 15:46:00 +00:00
Abhijeet Kasurde
367de4498b module_utils: remove deprecated compat.datetime APIs (#86018)
Fixes: #86000

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:43:28 -04:00
Abhijeet Kasurde
9a350ff104 git: removed deprecated gpg_whitelist alias (#86011)
Fixes: #86004

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:37:42 -04:00
Abhijeet Kasurde
9f1177a056 Removed parameter 'required' from get_bin_path API (#86009)
Fixes: #85998

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:37:03 -04:00
Abhijeet Kasurde
790b66f383 interpreter_discovery: removed auto_silent* option (#86006)
* interpreter_discovery: removed auto_silent* option

* Removed deprecated auto_silent* option from interpreter_discovery_python

Fixes: #85995

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Make CI green

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Make CI green I

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

---------

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-21 11:35:53 -04:00
Jason K Hall
192948434c galaxy: handle missing 'results' key in cached Galaxy API responses. (#85972)
* galaxy: handle missing 'results' key in cached Galaxy API responses.

* galaxy: clarified AnsibleError message for missing cache results.

* Modified AnsibleError message and added a regression test.

* Fixed formatting issue in test/units/galaxy/test_api.py

* Added a changelog entry.

* Modified changelog.
2025-10-21 11:27:24 -04:00
sivel / Matt Martz
d6051b18dd Add support for crypt/libxcrypt via ctypes, as an alternative to passlib (#85970)
* Add support for crypt/libxcrypt via ctypes, as an alternative to passlib

* move verbosity message to BaseHash

* Don't require DYLD_LIBRARY_PATH mods for standard homebrew installs on macos

* improve crypt_gensalt error handling
2025-10-21 11:24:57 -04:00
sivel / Matt Martz
f1f5b934c2 Update DataLoader to deal almost exclusively in str (#85941)
* Update DataLoader to deal almost exclusively in str

* source can be None as well

Co-authored-by: David Shrewsbury <Shrews@users.noreply.github.com>
2025-10-21 11:06:15 -04:00
Miro Hrončok
719681bbe2 Do not require wheel for building (#85533)
* Do not require wheel for building

- current version of setuptools (70.1+) does not need wheel at all
- older versions of setuptools would fetch wheel when building wheels (but not sdists)

* Pin setuptools to a version not requiring wheel

Now when we don't list wheel,
we are unable to pin it to a particular version.

Instead, use setuptools version that no longer uses it.
2025-10-21 01:35:19 +00:00
Brian Coca
ccfb7b1364 Fix include_role error consitency and add rescueable option (#86012)
* include_role now behaves more like task on error

changes _from errors from syntax to task failures, by default
which makes it more consistent with other existing errors
 * also force 'missing role' to behave as syntax error when false
 * also error when subdir does not exist, previouslly we ignored missing
   file
 * add 'rescuable' toggle to allow user to chose error type

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
2025-10-20 19:19:11 -04:00
Brian Coca
1cb2932c95 config lookup, fix 'show_origin' and variables (#85356)
show_origin and variable sources were broken for base config when 'forked' from plugins
---------
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
2025-10-20 19:15:00 -04:00
Jordan Borean
99bb587906 Remove AddType warning for cleanup (#86029)
Removes the warning emitted when using Add-Type and the cleanup of temp
files fails due to a file still being in use. The cleanup should be
handled by AnsibleModule on exit giving it more time to wait for any
open file handles to close. The exception is still present if calling
`Add-CSharpType` without an `AnsibleModule` object.
2025-10-21 06:35:31 +10:00
Brian Coca
22721b5d63 Slurp armor option (#85986)
* slurp, add option to deactivate the armor

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2025-10-17 18:09:30 -04:00
Sviatoslav Sydorenko
823c117563 Fix dry-run for notifications @ publish-codecov
Apparently `codecovcli send-notifications` does not have a `--dry-run`
CLI option. This patch stops adding it to the command and implements
an external `dry-run` mode in the wrapper script or this case instead.

This is a follow-up for #85968.

Co-authored-by: Matt Clay <matt@mystile.com>
2025-10-16 23:28:14 +02:00
sivel / Matt Martz
1a3e63c794 Don't deprecate six yet (#86020) 2025-10-16 12:56:23 -05:00
🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)
2799a684fc Explicitly notify Codecov about upload completion (#85968)
This patch add an additional invocation of Codecov CLI that tells the
backend that we're done uploading. It is supposed to stop Codecov from
guessing whether to wait for more uploads for the CI or start
processing them already.

Upstream refs:
* https://docs.codecov.com/docs/cli-options#send-notifications
* https://docs.codecov.com/docs/notifications#preventing-notifications-until-youre-ready-to-send-notifications
* https://docs.codecov.com/docs/codecovyml-reference#codecovnotifymanual_trigger
* https://github.com/codecov/codecov-cli/pull/195 (d634ebd8f2)
* https://github.com/codecov/codecov-action/issues/1436
* https://github.com/codecov/engineering-team/issues/107
* https://github.com/codecov/roadmap/issues/20
* https://github.com/codecov/feedback/discussions/204#discussioncomment-8796433
* https://github.com/codecov/engineering-team/issues/1245
* https://github.com/codecov/engineering-team/issues/3
* https://github.com/codecov/worker/pull/14 (71626b6368)
2025-10-15 08:50:25 -07:00
Martin Krizek
05d5b0f168 Avoid the ssh-agent exiting before tests end (#85979)
There were couple of occurrences where the hard 30 seconds limit on
running ssh-agent was not enough for the test to run and the ssh-agent
was killed resulting in the test failing with "Connection refused". This
change just lets the agent run in the background and kills it
manually after the tests finish.
2025-10-15 08:23:31 +02:00
sivel / Matt Martz
726e8d6548 Bump devel to 2.21 (#85992) 2025-10-14 15:35:21 -05:00
Michał Gąsior
9fcf1f7c58 Fix psrp - ReadTimeout exceptions now mark host as unreachable (#85974)
* psrp - ReadTimeout exceptions now mark host as unreachable

* add try to _exec_psrp_script

* fix indent E111

* update raise format

switch to raise Exception from e

Co-authored-by: Jordan Borean <jborean93@gmail.com>

---------

Co-authored-by: Jordan Borean <jborean93@gmail.com>
2025-10-15 05:59:00 +10:00
sivel / Matt Martz
c02f59ca3a fix urls in additional ansible-doc test (#85988) 2025-10-14 13:05:39 -05:00
Matt Clay
83c79240ec ansible-test - Update base/default/distro containers (#85985) 2025-10-13 16:39:17 -07:00
Matt Clay
7c2311d547 ansible-test - Upgrade coverage to 7.10.7 (#85981) 2025-10-13 14:30:14 -07:00
Matt Clay
de7dd5bbb2 ansible-test - Update pinned pip to 25.2 (#85982) 2025-10-13 21:00:17 +00:00
sivel / Matt Martz
5a9afe4409 Fix signal propagation (#85907) 2025-10-13 15:38:12 -05:00
Matt Clay
9ee667030f ansible-test - Update sanity test requirements (#85980) 2025-10-13 12:32:39 -07:00
Matt Clay
82b64d4b69 ansible-test - Update base/default containers (#85967) 2025-10-09 20:58:50 +00:00
Matt Clay
06456c68ec Use bcrypt < 5 for unit tests (#85969) 2025-10-09 19:32:27 +00:00
Sviatoslav Sydorenko
53afc6f203 Mention pkg name in package-data sanity output
The logs were displaying a series of numbers in parens like `(66.1.0)`
at the end of each error line. its unintuitive what that means. I had
to look into the source code to confirm my suspicion of it being the
version of `setuptools`. This patch spells it out.
2025-10-09 00:40:59 +02:00
Sviatoslav Sydorenko
0cd36ce6d0 Use strict_optional @ ansible.galaxy.dependency_resolution
This patch drops unnecessary default for
`CollectionDependencyProvider`'s `concrete_artifacts_manager` argument
as it is always passed, in every place across the code base where the
provider is constructed.

It was also causing MyPy violations on calls to
`_ComputedReqKindsMixin.from_requirement_dict()` in the "strict
optional" mode which is now enforced for $sbj, while remaining
disabled globally.

It is a #85545 follow-up.
2025-10-07 22:11:58 +02:00
Sviatoslav Sydorenko
c9131aa847 Type-annotate ansible.galaxy.dependency_resolution
This patch is a combination of `pyrefly autotype` and manual
post-processing. Parts of it migrate pre-existing comment-based
annotations, fixing incorrect ones where applicable.

The change also configures MyPy to run checks against actual
`resolvelib` annotations and includes a small tweak of
`ansible.galaxy.collection._resolve_depenency_map` to make it
compatible with those.

Co-Authored-By: Jordan Borean <jborean93@gmail.com>
Co-Authored-By: Matt Clay <matt@mystile.com>
Co-Authored-By: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
2025-10-07 09:55:10 +02:00
David Shrewsbury
feda8fc564 Fix flakey get_url test (#85953) 2025-10-06 18:42:03 -07:00
sivel / Matt Martz
6673a14a9e Update DataLoader.get_basedir to be an abspath (#85940) 2025-10-06 09:22:47 -05:00
s-hamann
0c7dcb65cf fetch - return file in result when changed is true (#85729)
Set the (source) file attribute in the return value if the file changed
(e.g. on initial fetch). The attribute is already set in all other
cases.
2025-10-03 08:28:41 -04:00
Martin Krizek
686c3658ae Deprecate ansible.module_utils.six (#85934)
* Deprecate `ansible.module_utils.six`

Fixes #85920
2025-10-02 13:17:03 -05:00
Sloane Hertel
cb2ecda514 Remove support for resolvelib < 0.8.0 (#85936)
* Remove support for resolvelib < 0.8.0

Remove code handling differences between resolvelib 0.5.3 and 0.8.0

Drop some versions from the test to reduce the time it takes to run

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>

* Remove type annotation

---------

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
2025-10-01 14:33:21 -07:00
Martin Krizek
313c6f6b4d Don't special case implicit meta tasks when filtering on tags (#85805)
* Don't special case implicit meta tasks when filtering on tags

Fixes #85475
2025-10-01 17:44:53 +00:00
Abhijeet Kasurde
6bee84318d known_hosts: return rc and stderr in fail_json (#85871)
* When ssh-keygen fails, return rc and stderr in fail_json
  in order to help debugging.

Fixes: #85850

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-10-01 16:07:29 +00:00
Martin Krizek
c3f87b31d1 import_tasks processing closer to include_tasks (#85877)
Fixes #69882
Closes #83853
Fixes #85855
Fixes #85856
2025-10-01 09:56:14 +02:00
Abhijeet Kasurde
c5e6227bdb falsy: Update doc (#85913)
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-09-30 17:19:10 +02:00
Luca Steinke
eafa139f77 fix description of truthy test (#85911)
There's a "not" too much here.

Maybe further examples can be found.
2025-09-30 17:18:38 +02:00
Felix Fontein
c6d8d206af Make sure ansible-doc doesn't crash when scanning collections whose path contains ansible_collections twice (#85361)
Ref: https://github.com/ansible/ansible/issues/84909#issuecomment-2767335761

Co-authored-by: s-hertel <19572925+s-hertel@users.noreply.github.com>
Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
2025-09-30 10:08:43 -04:00
Matt Davis
5125ec797c update 2.20 release codename (#85900) 2025-09-23 17:34:21 +00:00
Abhijeet Kasurde
5fc4b8c106 action: more debugging information (#85839)
* action: more debugging information

* Allow user to identify underlying problem with chmod, setfacl
  command.

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Review requests

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Review requests

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Review requests

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

---------

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-09-23 17:07:00 +02:00
🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко)
1e572ba5cc 🧪 Pin codecov-cli deptree used in AZP
PR #85888

`codecov-cli == 11.0.3` allows `click == 8.3.0` in its deps but the latter causes commit auto-discovery breakage in the former. With https://github.com/getsentry/prevent-cli/pull/95, `codecov-cli == 11.2.3` excludes this version so this patch updates the requirement to that.

To prevent this from happening again, the change also makes use of a pip constraint file that pins the entire dependency tree to concrete versions. The constraint file is managed by `pip-tools`.

Refs:
* https://github.com/getsentry/prevent-cli/pull/95
* https://github.com/pallets/click/issues/3066

ci_coverage
ci_complete
2025-09-23 15:07:00 +02:00