From ff228c9c97601c6a77501a73b287498062ba2d30 Mon Sep 17 00:00:00 2001 From: Ludo van Orden Date: Wed, 4 Jun 2025 22:19:06 +0200 Subject: [PATCH] fix builds with relative kubernetes-source paths --- .../nodeimage/internal/kube/builder_docker.go | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/pkg/build/nodeimage/internal/kube/builder_docker.go b/pkg/build/nodeimage/internal/kube/builder_docker.go index 7ff9348d..1f788b34 100644 --- a/pkg/build/nodeimage/internal/kube/builder_docker.go +++ b/pkg/build/nodeimage/internal/kube/builder_docker.go @@ -51,20 +51,6 @@ func NewDockerBuilder(logger log.Logger, kubeRoot, arch string) (Builder, error) // Build implements Bits.Build func (b *dockerBuilder) Build() (Bits, error) { - // cd to k8s source - cwd, err := os.Getwd() - if err != nil { - return nil, err - } - // make sure we cd back when done - defer func() { - // TODO(bentheelder): set return error? - _ = os.Chdir(cwd) - }() - if err := os.Chdir(b.kubeRoot); err != nil { - return nil, err - } - // capture version info sourceVersionRaw, err := sourceVersion(b.kubeRoot) if err != nil { @@ -102,6 +88,8 @@ func (b *dockerBuilder) Build() (Bits, error) { cmd := exec.Command("make", append( []string{ + "-C", + b.kubeRoot, "quick-release-images", "KUBE_EXTRA_WHAT=" + strings.Join(what, " "), },