Maksytka/kind
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/kind.git synced 2025-12-01 07:26:05 +07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3483 from tnqn/validate-ip-family

Browse Source 
Add ipFamily validation
This commit is contained in:
Benjamin Elder
2024-02-22 13:03:39 -08:00
committed by GitHub
parent d59e2ceb05 396586fde2
commit 2fb3f42eec
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/internal/apis/config/validate.go
View File

@@ -52,6 +52,11 @@ func (c *Cluster) Validate() error {
}
}
// ipFamily should be ipv4, ipv6, or dual
if c.Networking.IPFamily != IPv4Family && c.Networking.IPFamily != IPv6Family && c.Networking.IPFamily != DualStackFamily {
errs = append(errs, errors.Errorf("invalid ipFamily: %s", c.Networking.IPFamily))
}
// podSubnet should be a valid CIDR
if err := validateSubnets(c.Networking.PodSubnet, c.Networking.IPFamily); err != nil {
errs = append(errs, errors.Errorf("invalid pod subnet %v", err))

10
pkg/internal/apis/config/validate_test.go
View File

@@ -97,6 +97,16 @@ func TestClusterValidate(t *testing.T) {
}(),
ExpectErrors: 1,
},
{
Name: "bogus ipFamily",
Cluster: func() Cluster {
c := Cluster{}
SetDefaultsCluster(&c)
c.Networking.IPFamily = "ds"
return c
}(),
ExpectErrors: 1,
},
{
Name: "bogus serviceSubnet",
Cluster: func() Cluster {