Maksytka/linux
1
1
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-12-01 07:26:02 +07:00
Code Issues Packages Projects Releases Wiki Activity

coredump: fix core_pattern input validation

Browse Source 
In be1e028302 ("coredump: don't pointlessly check and spew warnings")
we tried to fix input validation so it only happens during a write to
core_pattern. This would avoid needlessly logging a lot of warnings
during a read operation. However the logic accidently got inverted in
this commit. Fix it so the input validation only happens on write and is
skipped on read.

Fixes: be1e028302 ("coredump: don't pointlessly check and spew warnings")
Fixes: 16195d2c7d ("coredump: validate socket name as it is written")
Reviewed-by: Jan Kara <jack@suse.cz>
Reported-by: Yu Watanabe <watanabe.yu@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Christian Brauner
2025-10-07 11:32:42 +02:00
parent 56094ad3ea
commit a779e27f24
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/coredump.c
View File

@@ -1468,7 +1468,7 @@ static int proc_dostring_coredump(const struct ctl_table *table, int write,
ssize_t retval; ssize_t retval;
char old_core_pattern[CORENAME_MAX_SIZE]; char old_core_pattern[CORENAME_MAX_SIZE];
if (write) if (!write)
return proc_dostring(table, write, buffer, lenp, ppos); return proc_dostring(table, write, buffer, lenp, ppos);
retval = strscpy(old_core_pattern, core_pattern, CORENAME_MAX_SIZE); retval = strscpy(old_core_pattern, core_pattern, CORENAME_MAX_SIZE);

2
fs/exec.c
View File

@@ -2048,7 +2048,7 @@ static int proc_dointvec_minmax_coredump(const struct ctl_table *table, int writ
{ {
int error = proc_dointvec_minmax(table, write, buffer, lenp, ppos); int error = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
if (!error && !write) if (!error && write)
validate_coredump_safety(); validate_coredump_safety();
return error; return error;
} }